Preserve device inventory across unavailable observations

test/server/device-inventory.test.js

@@ -116,7 +116,7 @@ test('malformed persisted devices and remote observations cannot enter canonical
   ]);
 });
 
-test('device inventory discovers, merges, persists metadata and expires anonymous devices', async (t) => {
+test('device inventory discovers, merges, persists metadata and expires devices after 30 days', async (t) => {
   const directory = fs.mkdtempSync(path.join(os.tmpdir(), 'harbor-devices-'));
   t.after(() => fs.rmSync(directory, { recursive: true, force: true }));
   const store = createJsonStore({ filePath: path.join(directory, 'devices.json'), defaultValue: {} });
@@ -169,6 +169,7 @@ test('device inventory discovers, merges, persists metadata and expires anonymou
   snapshot = await service.refresh();
   assert.equal(snapshot.devices.length, 1);
   assert.equal(snapshot.devices[0].confidence, 'ambiguous');
+  assert.equal(snapshot.devices[0].ip, '192.168.50.10');
 
   current = new Date('2026-07-01T10:05:00.000Z');
   observation = {
@@ -229,19 +230,23 @@ test('device inventory discovers, merges, persists metadata and expires anonymou
     (error) => error.code === 'REQUEST_INVALID',
   );
   const persisted = createDeviceInventoryService({ store, observe: async () => observation, vendor, now: () => current });
-  assert.equal(persisted.snapshot().devices.find(({ id }) => id === namedId).deprioritized, true);
+  snapshot = persisted.snapshot();
+  assert.equal(snapshot.devices.find(({ id }) => id === namedId).deprioritized, true);
+  snapshot = persisted.update(replacement.id, { pinned: true }, snapshot.revision);
+  assert.equal(snapshot.devices.find(({ id }) => id === replacement.id).pinned, true);
 
   observation = { observedAt: current.toISOString(), observations: [], error: 'source unavailable' };
   snapshot = await persisted.refresh();
   assert.equal(snapshot.devices.length, 2);
   assert.equal(snapshot.source.error, 'source unavailable');
 
-  snapshot = persisted.update(namedId, { alias: '' }, snapshot.revision);
   current = new Date('2026-08-02T10:00:00.000Z');
-  observation = { observedAt: current.toISOString(), observations: [], error: null };
+  observation = { observedAt: current.toISOString(), observations: [], error: 'source unavailable' };
   snapshot = await persisted.refresh();
-  assert.deepEqual(snapshot.devices.map(({ id }) => id), [namedId]);
-  snapshot = persisted.update(namedId, { deprioritized: false }, snapshot.revision);
+  assert.equal(snapshot.devices.length, 2);
+  assert.equal(snapshot.source.error, 'source unavailable');
+
+  observation = { observedAt: current.toISOString(), observations: [], error: null };
   snapshot = await persisted.refresh();
   assert.equal(snapshot.devices.length, 0);